-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2316] The Files page supports filtering by partition name and sorting by dictionary value #2343
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2343 +/- ##
============================================
- Coverage 52.69% 52.65% -0.05%
+ Complexity 4219 4216 -3
============================================
Files 511 511
Lines 29329 29346 +17
Branches 2851 2853 +2
============================================
- Hits 15454 15451 -3
- Misses 12630 12647 +17
- Partials 1245 1248 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that lost frontend code?
The front-end code needs to be provided by another pr |
shendanfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ams/server/src/main/java/com/netease/arctic/server/dashboard/controller/TableController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks a lot for you contribution.
Issue #2316 seems can not be closed yet cause the dashboard has not supported the filter feature. |
…sorting by dictionary value (apache#2343) * fix-2316 * fix-2316 * change param name --------- Co-authored-by: shendanfeng <shendanfeng01@corp.netease.com>
Why are the changes needed?
This is the backend implementation of #2316 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation